Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APPS-3058 Create FTVA variation of SectionStaffArticleList #653

Merged

Conversation

jendiamond
Copy link
Member

@jendiamond jendiamond commented Nov 14, 2024

Connected to APPS-3058
This FTVA styled component will be used on the EventSeries Listing page.

https://deploy-preview-653--ucla-library-storybook.netlify.app/?path=/story/section-staff-article-list--ftva-current-entries-with-dates

Notes:

  • src/lib-components/BlockStaffArticleList.vue
    • Moved all utils together
    • Add props
      • startDate
      • endDate
      • ongoing
    • Add the Theme and classes for Default & FTVA scss
    • Add the logic for the dates
      • parsedDateDisplay
    • Update the date formatting in formatSeriesDates
  • src/lib-components/SectionStaffArticleList.vue
    • Add calls to
      • startDate
      • endDate
      • ongoing
    • Add the Theme and classes for Default & FTVA scss
  • src/stories/BlockStaffArticleList.stories.js
    • Add stories and data for
      • FtvaDateRange
      • FtvaSameStartEndDate
      • FtvaOngoing
  • src/stories/SectionStaffArticleList.stories.js
    • Add stories and data for
      • FtvaDateRange
      • FtvaSameStartEndDate
      • FtvaOngoing
  • src/styles/_base.scss
    • import "default/_block-staff-article-item";
    • import "default/_section-staff-article-list";
  • src/styles/_ftva-theme.scss
    • import "ftva/_block-staff-article-item";
    • import "ftva/_section-staff-article-list";
  • Update styles
    • src/styles/default/_block-staff-article-item.scss
    • src/styles/default/_section-staff-article-list.scss
    • src/styles/ftva/_block-staff-article-item.scss
    • src/styles/ftva/_section-staff-article-list.scss
  • src/types/types.ts
    • Update the BlockStaffArticleListItemType with
      • startDate?: string
      • endDate?: string
      • ongoing?: boolean
  • src/utils/formatEventSeriesDates.js
    • Updates the Range to have the full year on both sides
Screenshot 2024-11-22 at 11 19 05 AM

Checklist:

  • I checked that it is working locally in the storybook
  • I checked that it is working locally in the
    library-website-nuxt dev server
    • My NPM Global is messed up so I can't check this.
  • I added a screenshot of it working
  • UX has reviewed and approved this
  • I used a conventional commit message
  • I assigned myself to this PR
Screenshot 2024-11-20 at 1 40 22 PM Screenshot 2024-11-20 at 1 40 41 PM

@jendiamond jendiamond added the feature feature label Nov 14, 2024
@jendiamond jendiamond self-assigned this Nov 14, 2024
Copy link
Contributor

Percy Screenshots

In order to conserve our percy screenshot allowance, percy is not configured to run automatically. Please make sure the PR is ready and all other checks are passing, then start it manually:

  1. Visit https://github.com/UCLALibrary/ucla-library-website-components/actions/workflows/percy.yml 2. Click the 'Run workflow' button in the blue bar. 3. Select the correct branch for this PR and click 'Run workflow' again to confirm.

Copy link
Contributor

github-actions bot commented Nov 14, 2024

@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 14, 2024 04:23 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 19, 2024 19:10 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 19, 2024 21:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 20, 2024 00:17 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 20, 2024 01:56 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 20, 2024 19:11 Inactive
@jendiamond jendiamond changed the title APPS-3058 Create FTVA variation of SectionStaffArticleList or Use SectionTeaserList feat: APPS-3058 Create FTVA variation of SectionStaffArticleList or Use SectionTeaserList Nov 20, 2024
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 20, 2024 19:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 20, 2024 19:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 20, 2024 19:51 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 20, 2024 20:50 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 20, 2024 20:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 20, 2024 21:28 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 22, 2024 17:21 Inactive
@jendiamond jendiamond changed the title feat: APPS-3058 Create FTVA variation of SectionStaffArticleList or Use SectionTeaserList feat: APPS-3058 Create FTVA variation of SectionStaffArticleList Nov 22, 2024
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 22, 2024 19:31 Inactive
src/lib-components/BlockStaffArticleList.vue Outdated Show resolved Hide resolved
src/lib-components/BlockStaffArticleList.vue Outdated Show resolved Hide resolved
src/lib-components/BlockStaffArticleList.vue Outdated Show resolved Hide resolved
src/lib-components/BlockStaffArticleList.vue Outdated Show resolved Hide resolved
src/lib-components/BlockStaffArticleList.vue Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 22, 2024 21:58 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 22, 2024 22:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 22, 2024 22:34 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 22, 2024 22:41 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 22, 2024 23:37 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 23, 2024 00:43 Inactive
@github-actions github-actions bot temporarily deployed to storybook--pull_request-653 November 23, 2024 00:51 Inactive
Copy link
Contributor

@pghorpade pghorpade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@pghorpade pghorpade merged commit 4a68214 into main Nov 26, 2024
9 checks passed
@pghorpade pghorpade deleted the APPS-3058_create-ftva-variation-of-section-staff-article-list branch November 26, 2024 21:08
pghorpade pushed a commit that referenced this pull request Nov 26, 2024
# [3.37.0](v3.36.0...v3.37.0) (2024-11-26)

### Features

* APPS-3058   Create FTVA variation of SectionStaffArticleList ([#653](#653)) ([4a68214](4a68214))
@pghorpade
Copy link
Contributor

🎉 This PR is included in version 3.37.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants